DIfferentiate Between Subject and Email #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spjmurray
force-pushed
the
fix_subjects
branch
2 times, most recently
from
10a6bb5 to
781bf9d
Compare
spjmurray
force-pushed
the
fix_subjects
branch
2 times, most recently
from
17cc104 to
5453dd7
Compare
This is kind inconsistent in that the subject is sometimes a service account ID and sometimes a user's email address. If we force it to be a user ID instead, this means lookups are quicker and less error prone, this forces clients into using the email claim, which they should use anyway, and may be slightly breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind inconsistent in that the subject is sometimes a service account ID and sometimes a user's email address. If we force it to be a user ID instead, this means lookups are quicker and less error prone, this forces clients into using the email claim, which they should use anyway, and may be slightly breaking.