lib: event_scheduler: rename to bm_scheduler #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
|
You can find the documentation preview for this PR here. |
lemrey
force-pushed
the
bm-scheduler
branch
2 times, most recently
from
da84c7f to
c93b253
Compare
anhmolt
reviewed
Nov 19, 2025
b-gent
approved these changes
Nov 19, 2025
|
|
||
| /** | ||
| * @brief An event to be scheduled for execution in the main thread. | ||
| * |
Contributor
There was a problem hiding this comment.
Check event handler typedef above.
Contributor
There was a problem hiding this comment.
I think it should be called something else than evt_handler_t, it is a bit too generic in my opinion.
Rename to bm_scheduler to follow the repository new naming scheme. Signed-off-by: Emanuele Di Santo <[email protected]>
|
|
||
| module=EVENT_SCHEDULER | ||
| module=BM_SCHEDULER | ||
| module-str=Event scheduler |
Contributor
There was a problem hiding this comment.
Shouldn't this be renamed too? Same for the prompt at the top
Contributor
Author
There was a problem hiding this comment.
Maybe, timer and buttons say: "Buttons library" and "Timer library"
The module-str instead says "Bare metal buttons" and "Bare metal timer"
Updates to the documentation, call the library "Bare Metal scheduler". Signed-off-by: Emanuele Di Santo <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to
bm_schedulerto follow the repository new naming scheme.