Skip to content

sqlserver #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sqlserver #11

wants to merge 4 commits into from

Conversation

Projetos2
Copy link

No description provided.

somatorio
somatorio reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@somatorio somatorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que tal arrumar esses passos no RUN que tem de instalação de pacotes ali? assim vai criar várias camadas desnecessárias além de gerar um cache dos pacotes disponíveis, e isso é anti-pattern

@Projetos2
Copy link
Author

Obrigado pelas dicas Marco. Melhoramos os passos no RUN, reduzindo assim o numero de camadas. Fique sempre a vontade de propor novas melhorias :)

@rogeriolino
Copy link
Member

@somatorio a vontade para fazer o merge, e/ou solicitar novas alterações.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somatorio somatorio somatorio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Projetos2 @rogeriolino @somatorio