Skip to content

Conversation

ondracka
Copy link
Contributor

Just something I messed up in the last patch, the parsed results were OK, just a warning was printed when it shouldn't be so add also few simple tests to catch this in future.

@ondracka
Copy link
Contributor Author

CC @ladinesa

@ondracka
Copy link
Contributor Author

I think this might have been forgotten... its really trivial.

@ladinesa
Copy link
Collaborator

Sorry I missed this, can you please send me the test files?

@ondracka
Copy link
Contributor Author

It is reproducible with the checked in test cases I even included some pytest testing.

@ondracka
Copy link
Contributor Author

Hm, actually I see this was fixed by you in unrelated commit 069f068 already.
So unless you want to commit the tests that a correct amount of warning is emitted, this can be dropped completely

@ladinesa
Copy link
Collaborator

Hm, actually I see this was fixed by you in unrelated commit 069f068 already. So unless you want to commit the tests that a correct amount of warning is emitted, this can be dropped completely

I will keep this open and work on it when I get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants