Skip to content

Conversation

ndaelman-hu
Copy link
Contributor

close #276

ndaelman added 5 commits February 28, 2025 16:34
- Fix incorrect handling of `get_n_electrons_safe`
- TODO: finish extraction band structure
@ndaelman-hu ndaelman-hu added the feature / enhancement New feature or request label Mar 4, 2025
@ndaelman-hu ndaelman-hu self-assigned this Mar 4, 2025
@coveralls
Copy link

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13662161373

Details

  • 30 of 61 (49.18%) changed or added relevant lines in 3 files are covered.
  • 75 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.07%) to 92.986%

Changes Missing Coverage Covered Lines Changed/Added Lines %
electronicparsers/quantumespresso/parser.py 24 55 43.64%
Files with Coverage Reduction New Missed Lines %
electronicparsers/edmft/parser.py 4 65.18%
electronicparsers/magres/parser.py 7 74.03%
electronicparsers/soliddmft/parser.py 12 94.65%
electronicparsers/abacus/parser.py 19 94.26%
electronicparsers/quantumespresso/parser.py 33 91.34%
Totals Coverage Status
Change from base Build 13653178014: -0.07%
Covered Lines: 35845
Relevant Lines: 38549

💛 - Coveralls

ndaelman added 7 commits March 4, 2025 21:14
- Extend serialization (UNFINISHED)
- TODO: extract reciprocal cell
- Fix NOMAD normalizer
- TODO: read high-symmetry points from files
-- Correct energy scale
-- Align bands with endpoints
@ndaelman-hu ndaelman-hu requested a review from ladinesa April 24, 2025 14:28
@ladinesa
Copy link
Collaborator

it appears that Band is a another module, in order to be consistent with the other qe nodule parsers, i suggest we make this also a separate parser. we unify them in the new parsers.

- Add extraction reciprocal cell
@ndaelman-hu
Copy link
Contributor Author

it appears that Band is a another module, in order to be consistent with the other qe nodule parsers, i suggest we make this also a separate parser. we unify them in the new parsers.

Yes, but the bandstructure calculation requires both a PWSCF calculation, as well as, a BAND calculation.
I'm fine splitting off BAND into its own module, but where should the processing of their combination occur?
Moreover, do you have an example of another module?

@ladinesa
Copy link
Collaborator

it appears that Band is a another module, in order to be consistent with the other qe nodule parsers, i suggest we make this also a separate parser. we unify them in the new parsers.

Yes, but the bandstructure calculation requires both a PWSCF calculation, as well as, a BAND calculation. I'm fine splitting off BAND into its own module, but where should the processing of their combination occur? Moreover, do you have an example of another module?

the other parsers are xspectra epw and phonon. they also require a pwscf calulation

@ndaelman-hu
Copy link
Contributor Author

Migrated to nomad-coe/workflow-parsers#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bandstructure support for QE
3 participants