Fix installation of prefix-retry.bash #721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @jasonkarns |
|
cc. @eregon |
|
So the goal is here to include the prefix-retry hook on installation, which is especially useful for folks who install this via a package manager like Homebrew, and don't have the source code on hand In my org a lot of repos prioritize nvm + avn with secondary support for nodenv, so there will be .nvmrc with a symlinked .node-version file I'm an advocate that engineers switch to nodenv because it's much simpler and more reliable, and the biggest hurdle is the nodenv install command. Since nvm requires a leading cc. @jasonkarns |
mfdj
changed the title
mfdj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #479 I attempted to include
prefix-retry.bashin the installation process. Turns outinstall -ddidn't recursively copy as I'd hoped.Had a spare moment so decided to tackle this again. Testing locally seems to get the right result!