fetch: handle invalid priority values properly #4522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves Web Platform Tests (WPT) conformance by properly handling invalid priority values in the fetch API. The changes ensure that the Request constructor and fetch function correctly throw TypeError exceptions when invalid priority values are provided, matching the expected web standard behavior.
- Adds proper validation for the
priorityoption in RequestInit with allowed values of 'high', 'low', and 'auto' - Updates test expectations to reflect that previously failing tests now pass
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/web/fetch/request.js | Adds priority field validation to RequestInit converter with allowed values and default |
| test/web-platform-tests/expectation.json | Updates test expectations to mark priority validation tests as passing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
metcoder95
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase wpt conformance, lol
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status