-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
style(sidebar): make hover full-width and add clearer item spacing #8158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the sidebar UI to improve user experience by making hover states more discoverable and improving visual consistency. The changes focus on making hover effects span the full width of sidebar items and adding consistent spacing between items.
- Full-width hover backgrounds for non-active sidebar items to improve discoverability
- Consistent gap spacing between sidebar items and groups
- Removal of double "pill" highlights by making label backgrounds transparent when row is highlighted
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css | Updates hover and active states to use full-width backgrounds, removes pill-style label backgrounds, and improves text contrast |
packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.module.css | Adds consistent gap spacing for item lists in sidebar groups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! Thanks 🙏 for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8158 +/- ##
==========================================
+ Coverage 76.58% 76.59% +0.01%
==========================================
Files 115 115
Lines 9602 9602
Branches 322 322
==========================================
+ Hits 7354 7355 +1
+ Misses 2247 2246 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Description
Validation
Screenshots:



Before:
After:
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.