feat(local-kms): start adding kms signature code #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation We currently use in memory keys for the Attestation key. While these keys are injected via an encrypted channel it is still not an ideal scenario. HSMs provide the highest level of security for private key management. In the AWS ecosystem, KMS provides a very cheap layer on top of HSMs with access managed by IAM roles. Importantly, the key material can never leave the HSMs. This is a step in the direction of using HSMs to sign transactions inside nocturne services. ## Solution Introduce local-kms into our docker-compose file. This will allow us to interact with KMS using the same tools that we will use in AWS but for local dev. We will likely allow in memory keys for backward compatibility and simplicity in local environments. ## Proof WIP ## PR Checklist - [n/a] added tests - [n/a] updated documentation - [n/a] added changeset if necessary - [n/a] tested in dev/testnet - [n/a] tested site with snap (we haven't automated this yet) - [n/a] re-built & tested circuits if any of them changed - [n/a] updated contracts storage layout (if contracts were updated)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently use in memory keys for the Attestation key. While these keys are injected via an encrypted channel it is still not an ideal scenario. HSMs provide the highest level of security for private key management. In the AWS ecosystem, KMS provides a very cheap layer on top of HSMs with access managed by IAM roles.
Importantly, the key material can never leave the HSMs. This is a step in the direction of using HSMs to sign transactions inside nocturne services.
Solution
Introduce local-kms into our docker-compose file. This will allow us to interact with KMS using the same tools that we will use in AWS but for local dev.
We will likely allow in memory keys for backward compatibility and simplicity in local environments.
Proof
PR Checklist