Move include declarations to targets for export #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring include directories on targets has the benefit that the declarations are propagated to the `INTERFACE_INCLUDE_DIRECTORIES` property in the CMake package file. This ensures that downstream projects can link to the imported CMake targets and get the correct include directories set automatically. The `target_include_directories` declarations follow the recommendation https://cmake.org/cmake/help/latest/command/target_include_directories.html so that the packages are **relocatable**. This in turn allows installing and testing without requiring `root` permissions. Following same recommendations, Boost headers are included using the imported target `Boost::boost`. This is available starting from CMake version 3.5, and the required version is updated accordingly. Signed-off-by: Eero Aaltonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring include directories on targets has the benefit that the
declarations are propagated to the
INTERFACE_INCLUDE_DIRECTORIESproperty in the CMake package file. This ensures that downstream
projects can link to the imported CMake targets and get the correct
include directories set automatically.
The
target_include_directoriesdeclarations follow the recommendationhttps://cmake.org/cmake/help/latest/command/target_include_directories.html
so that the packages are relocatable. This in turn allows
installing and testing without requiring
rootpermissions.Following same recommendations, Boost headers are included using the
imported target
Boost::boost. This is available starting from CMakeversion 3.5, and the required version is updated accordingly.
Signed-off-by: Eero Aaltonen [email protected]