-
-
Notifications
You must be signed in to change notification settings - Fork 128
Update tests and version regex #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Seems like a step in the right direction, once the cachix change is removed. I wonder if we could somehow automate keeping the list of NVidia driver versions up to date? |
.github/workflows/test.yml
Outdated
| name: guibou | ||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' | ||
| - uses: actions/checkout@v4 | ||
| - uses: cachix/install-nix-action@v30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is superseded by #201.
|
Thank you @jinluchang! I kept getting This PR fixed the issue. I hope it gets merged soon. |
The conflicts need resolving first. Since it was left untouched for a while I don't know if @jinluchang is interested in continuing with it. If not, you could pick it up, @samestep. |
|
Oh sure @dyfrgi, I can take a look. I'm guessing I can't edit this PR, should I just open a separate one? |
|
@jinluchang looks like the build is failing? |
|
@samestep The failure is due the recent commit "fix: set GBM_BACKENDS_PATH" 3865170 which add "export GBM_BACKENDS_PATH=${lib.makeSearchPathOutput "lib" "lib/gbm" mesa-drivers}" to nixGL. This change caused the test to fail. However, the test would work with more recent nixpkgs. Perhaps we should advance the rev in "nixpkgs.nix"? |
|
@dyfrgi is this ready to be merged now? |
|
@dyfrgi are there any blockers for merging this? |
Mainly change the regex ".Module ([0-9.]+) ." to ".NVIDIA UNIX.Kernel Module. ([0-9]+\.[0-9]+) ." in file nixGL.nix to accommodate new version string.