fix: build on non-x86 (aarch64) platforms #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a few issues that I have been encountering when using NixGL in nix-shell and as a runtime dependency on a Raspberry Pi 5 (aarch64):
enable32bitsparameter was always on by default, causing trouble down the line. It has now been changed to be on by default when on an x86 system and off otherwise.pkgsi686Linuxanddriversi686Linuxwere always being pulled as package dependencies regardless of whetherenable32bitswas on or not, making the build fail since they are not available on ARM. They now only get pulled in ifenable32bitsis on.auto.nixGLDefaultwould always fall back tonixGLIntel, pulling in and attempting to build the Intel display drivers without much of a need for them. Fallback has been changed to usenixGLIntelon an x86 system and tonixGLMesaelsewhere.I hope to not have broken anything else - unfortunately I have not had the occasion to test this on an x86 PC.