Add support for recursive search #129
Conversation
The Nix, Lix & Snix (twix) codebase both support a recursive call for the lookup of the input derivation replacement paths. Augment hashes.go to include the ability to recursively lookup derivations and calculate their paths. A demonstration of this is done in the test but it can also be done by looking up derivations on the /nix/store filesystem for instance.
| // the calculation would be recursive. | ||
| // | ||
| // We solve this having calculateDrvReplacement accept a map of | ||
| // /its/ replacements, instead of recursing. |
There was a problem hiding this comment.
The diff is a bit hard to read, but this docstring does explicitly say we expect a (immutabe) hashmap with the hashes already precomputed. Doing a call to CalculateDrvReplacementRecursive inside then seems wrong.
flokli
left a comment
flokli
left a comment
There was a problem hiding this comment.
It's been a while since I touched this code, but I'd feel more comfortable if the code would be moved around the bit, so CalculateDrvReplacement does not call CalculateDrvReplacementRecursive.
|
@flokli up to you on the change. I thought that the original code can be replaced with the recursive variant with a fixed function provider was a good demonstration of the interface ,😅🫠 |
2 participants
The Nix, Lix & Snix (twix) codebase both support a recursive call for the lookup of the input derivation replacement paths.
Augment hashes.go to include the ability to recursively lookup derivations and calculate their paths.
A demonstration of this is done in the test but it can also be done by looking up derivations on the /nix/store filesystem for instance.