fixes #24974; SIGSEGV when raising Defect/doAssert #24985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jun 9, 2025
| @@ -1234,7 +1234,9 @@ proc allPathsAsgnResult(p: BProc; n: PNode): InitResultEnum = | |||
| else: | |||
| allPathsInBranch(n[i].lastSon) | |||
| of nkCallKinds: | |||
| if canRaiseDisp(p, n[0]): | |||
| if canRaiseDisp(p, n[0]) or | |||
| (n[0].kind == nkSym and sfNoReturn in n[0].sym.flags): | |||
There was a problem hiding this comment.
But there can be calls that don't return that are not marked as noreturn.
There was a problem hiding this comment.
Other cases are already covered by canRaiseDisp, which is quite conservative about functions that never raises. In general, only functions in the system can be exempt from this checking. Otherwise, we have systemRaisesDefect for functions in the system
e.g.
proc `[]`*[T](s: openArray[T]; i: BackwardsIndex): T {.inline, systemRaisesDefect.} =
system.`[]`(s, s.len - int(i))We can treat noreturn function calls consistently as result must be initialized in these cases
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24974
requires
resultinitializations when encountering unreachable code (e.g.quit)