This repository was archived by the owner on Nov 9, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Crash app when drag and drop item in listview #372
Open
khiemvu
wants to merge
25
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, drag and drop handler chooses a list item which is located at some moved point. But it has little difference from the point at touch down. This pull request fixes DragAndDropHandler to drag a list item which is located at touch down.
…wrap StickyListHeaders item before trying to find ListViewAnimations' tags from it
…ner.dismissPending().
…thout flinging it sideways. Fixes #245.
…oter view using SimpleSwipeUndoAdapter. Fixes #277.
Also updated the Exception messages to contain the new setListViewWrapper method.
These should be generated by eclipse at maven project import.
Update maven config
… to work on API 8 or higher. Fix running example app on Emulator without Google Play Store. Fix most problems with drag&drop on API levels < 14. Also contains fix for #254 refresh mMobileView only when needed. Fix visible mobileView when dragging on API < 14. This works only when SimpleSwipeUndo is enabled too. When it's not enabled the mobileView remains is visible. Some cleanup, fixed scroll item swapping.
…ent Variables online.
…stItemAdapter Added setAbsListView to ExpandableListItemAdapter
Enabled refreshMobileView for all API's. Shorter test delays.
I am also facing the same problem while doing drag and drop operation in list view. Problem in DragAndDropHandler.java at line #588 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I use listviewanimations in my app, and sometime app force close when i drag and drop item in listview
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference
at com.nhaarman.listviewanimations.itemmanipulation.dragdrop.DragAndDropHandler$LSwitchViewAnimator$AnimateSwitchViewOnPreDrawListener.onPreDraw(DragAndDropHandler.java:588)
at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:921)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2214)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1230)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6748)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:777)
at android.view.Choreographer.doCallbacks(Choreographer.java:590)
at android.view.Choreographer.doFrame(Choreographer.java:560)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:763)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:6117)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
I don't understand why althought at line 588 in DragAndDropHandler.java really check not null before