Skip to content

Conversation

@HerrDerb
Copy link

Adds #1590 (Add possibility to inform on fallback language use)

@HerrDerb HerrDerb changed the title feat(translation-store)): add subject to inform on fallback lang use feat(translation-store): add subject to inform on fallback lang use Aug 11, 2025
@rbalet
Copy link
Collaborator

rbalet commented Aug 11, 2025

Thanks for this PR.

Shall I know what you put it as private and how is your plan of consuming it?

@HerrDerb
Copy link
Author

@rbalet sorry, the getter was missing 🙈

@HerrDerb
Copy link
Author

and tests are still missing too

@CodeAndWeb
Copy link
Member

Thank you for the PR.

I’m afraid I can’t accept it at this time. It would add complexity to the library while offering limited benefit to most users.

We already provide similar functionality through the MissingTranslationHandler, which you can easily customize in your project to achieve the same result.

@CodeAndWeb CodeAndWeb closed this Aug 13, 2025
@HerrDerb
Copy link
Author

@CodeAndWeb must have overlooked that one (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants