Allow disabling cert-generator with a Helm value #4186
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fabian4! Thanks for opening this pull request! |
Problem: Need to allow disabling cert-generator with a Helm value. Solution: Allow disabling cert-generator with a Helm value. Testing: Allow disabling cert-generator with a Helm value.
fabian4
force-pushed
the
allow_disabling_cert_generator
branch
from
a054b7b to
56a2aaf
Compare
github-actions
bot
added
the
documentation
sjberman
reviewed
Oct 29, 2025
| # -- The certGenerator section contains the configuration for the cert-generator Job. | ||
| certGenerator: | ||
| # -- Enable or disable the cert-generator Job. | ||
| disable: false |
There was a problem hiding this comment.
Let's flip this to enable: true to match the pattern set elsewhere in this values file. Also, let's update the comment to say that if this is disabled, then cert-manager or some other method must be used to create the Secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow disabling cert-generator with a Helm value
Closes #4173
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.