fix: include metrics in the helper template agent config

[dareste]

Proposed changes

Fixes #8407

The agent configuration that is included in the Helm chart does not work as expected in scenarios where App Protect is enabled and we are sending security events to NIM (WAF Security Monitoring solution).

Right now, the config file that is generated only enables the feature metrics-sender, which results in the agent being ready to send events, but not collecting them. To actually collect the events we need to include the metrics-collection feature as well.

The solution proposed in this PR is to replace the metrics-sender feature with the metrics one, which includes both collect and send features.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• [x ] I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• [x ] I have rebased my branch onto main
• [x ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[pdabelf5]

@dareste Can you log an issue describing the problem so the team can review? Thanks!

[AlexFenlon]

Hi @dareste,

Can you also run make test-update-snaps to fix the unit tests!

[Copilot]

Pull Request Overview

This PR fixes the NGINX Ingress Controller Helm chart configuration to properly enable App Protect security event collection. The change replaces the metrics-sender feature with the metrics feature, which includes both collection and sending capabilities needed for WAF Security Monitoring with NIM.

• Replaces metrics-sender with metrics in the helper template for agent configuration
• Updates test snapshots to reflect the configuration change and new hash values

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
charts/nginx-ingress/templates/_helpers.tpl	Updates agent configuration to use metrics instead of metrics-sender
charts/tests/snapshots/helmunit_test.snap	Updates test snapshots with new configuration and corresponding hash changes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}