-
Notifications
You must be signed in to change notification settings - Fork 101
feature: Secure your fleet, NGINX One #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small LOGAF non-blocking edit suggestions.
If the PR replaces #637, then that should probably be closed.
I find the order in which the docs are presented confusing. Is "Manage your fleet" really before "Get started"? Shouldn't "Manage your instances" include items like Connect your instances and Draft configurations? I could see 3 top-level headings on the landing page: Get started, Secure your fleet, and Manage your fleet. Or maybe 4, if we also add one for Admin tasks (like RBAC, metrics, etc.). |
Will be addressed in an internal issue (num-200 in internal-docs repo) |
2caef64
to
7152a0d
Compare
2f9fbfe
to
cb81103
Compare
@travisamartin thank you for the detailed review. I've accepted all but 2 of your suggestions. |
40b4b3d
to
783a943
Compare
b40ab0a
to
5e39326
Compare
This commit adds a new landing page archetype, which has the ability to display various cards to highlight specific items. The archetype includes inline guidance like other archetypes, including explanations of new frontmatter parameters and a new card shortcode. --------- Co-authored-by: Mike Jang <[email protected]> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Travis Martin <[email protected]>
5de175a
to
92057f0
Compare
566259e
to
1fc2ede
Compare
Co-authored-by: Travis Martin <[email protected]>
1. Select **Add Item** | ||
|
||
You've now set up F5 Distributed Cloud to send you alerts from the NGINX One Console to your email. When an alert is triggered, you'll receive a message from **[email protected]**. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on separate discussions, @jasonclopper @travisamartin
## Known issues | |
When you set up an email alert that recognizes a problem, you'll see the alert in: | |
- The F5 Distributed Cloud Console, in **Audit Logs & Alerts**, under **Notifications > Alerts**. | |
- An email with a subject line like **<number> Alert Requires Action**. | |
As defined in our [Alert Reference](https://docs.cloud.f5.com/docs-v2/platform/reference/alerts-reference), after a certain period of time, you may also receive an "Alert Resolved" email. | |
For CVEs, the authoritative source is in **NGINX One**, under **Manage > Instances > <Instance hostname>.** See the list of CVEs on the dashboard details for that instance. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section doesn’t describe the actual issue. The problem is that users may receive “Alert Resolved” emails even when the issue still exists, which is misleading.
If we don’t call out that behavior directly, I’m not sure “Known issues” is the right heading. As it stands, the text just tells users to defer to NGINX One Console as the source of truth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: If you want to document this as a known issue, I recommend creating a KB article and linking to it from here. The KB system is the right place for that kind of content. It also helps make sure Global Services is aware of the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename /secure-your-fleet/secure.md
could be more descriptive.
Maybe /secure-your-fleet/set-up-security-alerts.md
? That'd match the doc title.
Proposed changes
Create end-to-end "use-case" documentation for admins / security engineers who want to use NGINX One Console to "Secure your fleet".
Fleets of NGINX deployments frequently include dozens and many more instances. With this use case, an admin/security engineer can set up the NGINX One Console to send them alerts for appropriate issues. Today, those issues include CVEs and other detected security "misconfigurations" identified by NGINX One Console.
This use case goes somewhat beyond NGINX One Console. This PR removes roadblocks to success in the following ways:
It clarifies what users need to access the NGINX One Console, specifically with:
It then shows users, step by step, how to set up notifications when one/more of their instances have CVEs and other detected security issues.
Replaces #637
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩