Fixes #68 Setting Up Initial Tests

cardie/authentication/test_authentication.py

@@ -0,0 +1,127 @@
+import pytest
+from django.test import RequestFactory
+from django.urls import reverse
+from django.utils import timezone
+from main.models import Server
+
+from authentication.models import User
+from authentication.views import create_account, sign_in
+
+
+@pytest.fixture
+def server():
+    server = Server.objects.create(ip='127.0.0.1', production=False, allow_create_accounts=True, allow_sign_in=True)
+    return server
+
+@pytest.mark.django_db
+def test_create_user(server):
+    # Create a new user
+    user_data = {
+        'Username': 'testuser',
+        'Password': 'testpassword',
+        'Email': '[email protected]',
+        'date_created': timezone.now()
+    }
+    # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('createaccount'), user_data)
+    request.headers=user_data
+    request.headers['Internal'] = True
+    # Call the create_account view function with the mock request object
+    response = create_account(request)
+
+    assert response.status_code == 200
+
+@pytest.mark.django_db
+def test_create_user_with_no_username( server):
+    # Create a new user
+    user_data = {
+        'Username': 'testuser',
+        'Password': '',
+        'Email': '[email protected]',
+        'date_created': timezone.now()
+    }
+    # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('createaccount'), user_data)
+    request.headers=user_data
+    # Call the create_account view function with the mock request object
+    response = create_account(request)
+
+    # Assert that the response status code is not 200
+    assert response.status_code != 200
+
+@pytest.mark.django_db
+def test_create_user_with_no_email( server):
+    # Create a new user
+    user_data = {
+        'Username': 'testuser',
+        'Password': 'testpassword',
+        'Email': '',
+        'date_created': timezone.now()
+    }
+    # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('createaccount'), user_data)
+    request.headers=user_data
+    # Call the create_account view function with the mock request object
+    response = create_account(request)
+
+    # Assert that the response status code is not 200
+    assert response.status_code != 200
+
+@pytest.mark.django_db
+def test_create_user_with_no_password( server):
+    # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('createaccount'), {'Username': '', 'Password': 'password', 'Email': '[email protected]'})
+    request.headers={ 'Username': '', 'Password': 'password', 'Email': '[email protected]' }
+    # Call the create_account view function with the mock request object
+    response = create_account(request)
+
+    # Assert that the response status code is not 200
+    assert response.status_code != 200
+
+@pytest.mark.django_db
+def test_create_user_duplicate_username(server):
+    user_data = {
+        'Username': 'testuser',
+        'Password': 'testpassword',
+        'Email': '[email protected]',
+        'date_created': timezone.now(),
+    }
+    # First create a user
+    User.objects.create(username=user_data['Username'], email=user_data['Email'], password=user_data['Password'], date_created=user_data['date_created'])
+
+    # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('createaccount'), user_data)
+    request.headers=user_data
+
+    # Call the create_account view function with the mock request object
+    response = create_account(request)
+
+    # Assert that the response status code is not 200
+    assert response.status_code != 200
+
+@pytest.mark.django_db
+def test_signin_user(server):
+    # Try to create a user with a duplicate email
+    user_data = {
+        'Username': 'testuser',
+        'Password': 'testpassword',
+        'Email': '[email protected]',
+        'date_created': timezone.now(),
+    }
+    # First create a user
+    User.objects.create(username=user_data['Username'], email=user_data['Email'], password=user_data['Password'], date_created=user_data['date_created'])
+
+     # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse('sign_in'), user_data)
+    request.headers=user_data
+
+    # Call the create_account view function with the mock request object
+    response = sign_in(request)
+
+    assert response.status_code == 200

cardie/authentication/views.py

@@ -1,23 +1,23 @@
+import uuid
+
+from django.contrib.auth.hashers import check_password, make_password
 from django.shortcuts import HttpResponse
-from django.contrib.auth.hashers import make_password, check_password
+from django.utils import timezone
+from main import views
+from main.models import Card, Server, TempCard
 
 from authentication.models import User
-from main.models import Server, Card, TempCard
-from main import views
 
-from django.utils import timezone
-import uuid
 
 def sign_in(request):
     server = Server.objects.all()[0] # TODO: What if there is multiple server objects?
-
+    
     if server.allow_sign_in:
         if "Username" in request.headers and "Password" in request.headers:
             username = request.headers["Username"]
             password = request.headers["Password"]
 
             signed_in = True
-
         else:
             try:
                 username = request.session["username"]
@@ -26,10 +26,8 @@ def sign_in(request):
                 signed_in = True
 
             except KeyError:
-                print("Missing headers and no session!")
-                return HttpResponse("error_missing_headers_and_session")
+                return HttpResponse("error_missing_headers_and_session",status_code=400)
 
-
         if signed_in:
             users = User.objects.filter(username=username)
 
@@ -53,7 +51,7 @@ def sign_in(request):
 
                     except KeyError:
                         pass
-
+                    
                     if request.headers["Internal"] == "true":
                         return HttpResponse("success")
 
@@ -74,40 +72,41 @@ def sign_in(request):
 
 def create_account(request):
     server = Server.objects.all()[0] # TODO: What if there is multiple server objects?
-
+    print(server.allow_create_accounts)
     if server.allow_create_accounts:
         if "Username" in request.headers and "Password" in request.headers and "Email" in request.headers:
             username = request.headers["Username"]
             password = request.headers["Password"]
             email = request.headers["Email"]
-
+            
             if username == "":
-                return HttpResponse("no_username")
+                return HttpResponse("no_username",status=400)
 
             if password == "":
-                return HttpResponse("no_password")
-
+                return HttpResponse("no_password",status=400)
+            
             if email == "":
-                return HttpResponse("no_email")
-
+                return HttpResponse("no_email",status=400)
 
             users = User.objects.filter(username=username)
-
+            
             if len(users) > 0:
-                return HttpResponse("error_account_already_exists")
+                return HttpResponse("error_account_already_exists",status=400)
 
             else:
                 hashed_password = make_password(password)
 
                 user = User(username=username, password=hashed_password, email=email, date_created=timezone.now())
                 user.save()
 
-                request.session["username"] = username
-                request.session["password"] = password
-
+                request.session = {
+                    "username": username,
+                    "password": password
+                    }
+
                 return sign_in(request)
 
         else:
-            return HttpResponse("error_missing_headers")
+            return HttpResponse("error_missing_headers",status=400)
     else:
-        return HttpResponse("error_create_account_disabled")
+        return HttpResponse("error_create_account_disabled",status=400)

cardie/main/test_card.py

@@ -0,0 +1,139 @@
+import uuid
+
+import pytest
+from authentication.models import User
+from authentication.views import sign_in
+from django.test import RequestFactory
+from django.urls import reverse
+from django.utils import timezone
+
+from main.models import Server
+from main.views import check_card, create_card, delete_card
+
+CARD_VIEWS = {
+    'CHECK_CARD' : 'checkcard',
+    'CREATE_CARD' : 'createcard',
+    'DELETE_CARD' : 'deletecard',
+    'SIGN_IN' : 'signin',
+    'RENAME_CARD' : 'renamecard'
+}
+
+# NOTE:Tests can only access the data in current session. 
+# In accordance with DRY principle create a fixture to avoid repetition in tests
+@pytest.fixture
+def server():
+    print("Running server fixture")
+    server = Server.objects.create(ip='127.0.0.1', production=False, allow_create_accounts=True, allow_sign_in=True)
+    return server
+
+@pytest.fixture
+def user(server):
+    print("server in user fixture",server)
+    ## Try to create a user with a duplicate email
+    user_data = {
+        'Username': 'testuser',
+        'Password': 'testpassword',
+        'Email': '[email protected]',
+        'date_created': timezone.now(),
+    }
+    # First create a user
+    User.objects.create(username=user_data['Username'], email=user_data['Email'], password=user_data['Password'], date_created=user_data['date_created'])
+
+     # Create a mock request object
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['SIGN_IN']), user_data)
+    request.headers=user_data
+    request.headers['Internal'] = True
+
+    # Call the create_account view function with the mock request object
+    response = sign_in(request)
+    return (user_data, response) # Return the user data and response
+
+@pytest.fixture
+def card(user):
+    user_data = user[0]
+    uuid_data = {'UUID' : uuid.uuid4()}
+    # Create card for signed in user
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['CREATE_CARD']), uuid_data)
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = uuid_data
+
+    response = create_card(request)
+    return (user_data, uuid_data, response) # Return the user data, uuid and response
+
+@pytest.mark.django_db
+def test_create_card(server,user):
+    user_data = user[0]
+    # Create card for signed in user
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['CREATE_CARD']), {'UUID': 'testuuid'})
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = {'UUID' : uuid.uuid4()}
+
+    response = create_card(request)
+
+    # Assert that create_card returns 200
+    assert response.status_code == 200
+
+@pytest.mark.django_db
+def test_check_created_card(server,card):
+    user_data = card[0]
+    uuid_data = card[1]
+
+    # Check the created card exists
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['CHECK_CARD']), uuid_data)
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = uuid_data
+
+    response = check_card(request)
+
+    # Assert that create_card returns 200
+    assert response.status_code == 200
+
+@pytest.mark.django_db
+def test_delete_card(server,card):
+    user_data = card[0]
+    uuid_data = card[1]
+    print("uuid_data", uuid_data)
+    # Check the created card exists
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['DELETE_CARD']), uuid_data)
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = uuid_data
+
+    response = delete_card(request)
+
+    # Assert that create_card returns 200
+    assert response.status_code == 200
+
+@pytest.mark.django_db
+def test_delete_card_that_doesnt_exist(server,card):
+    user_data = card[0]
+    uuid_data = {'UUID' : uuid.uuid4()}
+    # Check the created card exists
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['DELETE_CARD']), uuid_data)
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = uuid_data
+
+    response = delete_card(request)
+
+    # Assert that create_card returns 404 (not found)
+    assert response.status_code == 404
+
+@pytest.mark.django_db
+def test_rename_card(server,card):
+    user_data = card[0]
+    uuid_data = card[1]
+    # Check the created card exists
+    factory = RequestFactory()
+    request = factory.post(reverse(CARD_VIEWS['RENAME_CARD']), uuid_data)
+    request.session = {'username' : user_data['Username'],'password' : user_data['Password']}
+    request.headers = uuid_data
+
+    response = delete_card(request)
+
+    # Assert that create_card returns 404 (not found)
+    assert response.status_code == 404