Fix compilation issues on Windows #734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work! |
Hi. Would you mind tell me what environment you are using? MSYS2, MSVC or others? |
ikspress
force-pushed
the
win32-compilation
branch
from
58e2e3d to
087e24e
Compare
ikspress
force-pushed
the
win32-compilation
branch
from
087e24e to
f54f591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to solve compilation issues on Windows and I have revised my PRs serveral times. Hopefully this will be my last revision, maybe...
The purpose of this PR is as follows.
Accoring MSDN and mingw-w64,
snprintf()works properly now. In #718, I took mingw-w64-crt's implementation ofsnprintf(), but it unchanged here.