Skip to content

Conversation

@fellen31
Copy link
Contributor

@fellen31 fellen31 commented Nov 12, 2025

This PR fixes some issues with the chromograph module:

  • Tag being [] when not using the autozyg input
  • Emit the actual files instead of the directory
  • Remove prefix, it has no effect on the naming of output files from this program
  • Somewhat realistic stub outputs. When not running with --euploid the actual program will output all chrs present in the input file(s) and name them according to the input files (e.g. chr1 or 1), but that's hard to replicate fully.
  • More rigorous tests

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@fellen31 fellen31 force-pushed the chromograph-outputs branch 3 times, most recently from 3d8f380 to 7f234e7 Compare November 12, 2025 15:51
@fellen31 fellen31 force-pushed the chromograph-outputs branch from 7f234e7 to fc5accb Compare November 12, 2025 15:51
@fellen31 fellen31 marked this pull request as ready for review November 12, 2025 16:01
@fellen31 fellen31 requested a review from ramprasadn November 13, 2025 08:06
@fellen31 fellen31 requested a review from SPPearce November 14, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants