Add module: TRIDENT_FETCH
#9360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itrujnara
reviewed
Nov 11, 2025
Contributor
itrujnara
left a comment
itrujnara
left a comment
There was a problem hiding this comment.
Hi @TCLamnidis, nice submission. I have left some minor comments.
|
|
||
| } | ||
|
|
||
| test("2012_MeyerScience-2.1.1 - fetchString - stub") { |
Contributor
There was a problem hiding this comment.
A test for fetchFile is missing
| @@ -0,0 +1,70 @@ | |||
| process TRIDENT_FETCH { | |||
| tag "" | |||
Contributor
There was a problem hiding this comment.
Can we somehow infer the tag from the input values?
| : 'biocontainers/poseidon-trident:1.6.7.1--hebebf5b_1'}" | ||
|
|
||
| input: | ||
| tuple path(archive_dir), val(fetch_s), path(fetch_fn) |
Contributor
There was a problem hiding this comment.
Are you sure that a meta map will never be useful here?
| type: file | ||
| description: The genotype files of any newly downloaded package(s). | ||
| pattern: "output_archive/*/*.{geno,bed,vcf,geno.gz,bed.gz,vcf.gz}" | ||
| ontologies: [] |
Contributor
There was a problem hiding this comment.
Some outputs (at least this one) should have some suitable ontology. Can you please check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds modules for
trident:PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda