error message of azcopy is no longer hidden #6187
Open
+79
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6158 Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: adamrtalbot <[email protected]>
This seems to work with both files and directories with no issue. I tested it with: ```bash make pack && ./build/releases/nextflow-25.05.0-edge-dist run nf-core/rnaseq -r 3.19.0 -profile test --outdir results -c azure.config -w az://work/ BUILD_PACK=1 ./gradlew pack ``` And it worked fine? Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
This reverts commit cfdf0cb. Signed-off-by: adamrtalbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When azcopy failed due to resource constraints, it hid the error message making it hard to debug and raising a new error in it's place. This PR refactors the bash for nxf_az_download to handle the error better and surface it back to Nextflow where it can be handled by an errorStrategy.
turns out, if you just replaceazcopy cpwithazcopy sync --recursiveit works fine 🤷 , I tested it with nf-core/rnaseq and it worked: