-
Notifications
You must be signed in to change notification settings - Fork 695
Migration guide for workflow outputs #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested headings to the bullet points as I think it's easier to scan.
Before making suggestion to the example migration, did you want it to be follow along? Or something more demonstration with explanations?
This will impact some of the language:
"Declare an output for each channel..." vs "An output channel for each must be declared..."
Signed-off-by: Ben Sherman <[email protected]>
Thanks Chris, all great improvements It is mostly a follow-along, with some explanation sprinkled throughout. I need to guide the reader through a specific example while also pausing at times to make more general points. The current version is my best attempt to balance these things |
Great. The steps you have included are already great, so I'll make suggestions that tweak the language to make it consistent as a follow-along. |
From our discussion last week, we will follow up this PR with a separate tutorial about the rnaseq-nf pipeline to give more context. Also, this guide is really more of a tutorial, but we already renamed the section from "Tutorials" to "Guides". Once we move to seqera docs, we should have explicit sections for both I also wouldn't be opposed to just having a "Guides" and "Tutorials" section in the current docs? I just didn't want to keep renaming the current section back and forth |
No description provided.