fix: change default trash deletion setting from enabled to disabled

shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderConfig.swift

@@ -33,7 +33,7 @@ struct FileProviderConfig {
     }
 
     var trashDeletionEnabled: Bool {
-        get { internalConfig[ConfigKey.trashDeletionEnabled.rawValue] as? Bool ?? true }
+        get { internalConfig[ConfigKey.trashDeletionEnabled.rawValue] as? Bool ?? false }
         set { internalConfig[ConfigKey.trashDeletionEnabled.rawValue] = newValue }
     }
 

src/gui/macOS/fileprovidersettingscontroller_mac.mm

@@ -378,12 +378,12 @@ void initialCheck()
 {
     const auto xpc = FileProvider::instance()->xpc();
     if (!xpc) {
-        return true;
+        return false;
     }
     if (const auto trashDeletionState = xpc->trashDeletionEnabledStateForExtension(userIdAtHost)) {
         return trashDeletionState->first;
     }
-    return true;
+    return false;
 }
 
 bool FileProviderSettingsController::trashDeletionSetForAccount(const QString &userIdAtHost) const

src/gui/macOS/fileproviderxpc_mac.mm

@@ -216,7 +216,7 @@
         return std::nullopt;
     }
 
-    __block BOOL receivedTrashDeletionEnabled = YES; // What is the value of the setting being used by the extension?
+    __block BOOL receivedTrashDeletionEnabled = NO; // What is the value of the setting being used by the extension?
     __block BOOL receivedTrashDeletionEnabledSet = NO; // Has the setting been set by the user?
     __block BOOL receivedResponse = NO;
     dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);