Bugfix/incorrect context menu activation fix #8425 #8463
+17
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #8425
Note to reviewers
Context
In the scenario detailed in the bug report the "Free up local space" context menu item is deactivated, because the directory's pin state is online only. The pin state is checked in a non-recursive way, the pin state of sub-items are completely disregarded.
Solution
To solve this, I check the pin state recursively. This way the result will be "all hydrated", or "mixed" (according to contents) which will activate said context menu item.
Considerations
This idea might not be the best, because it introduces a performance issue. If the directory has a lot of sub items, the recursive check might take a long time. For this reason I attempted to make the recursive check slightly faster, however this alone won't solve the possible performance issue.