feat(windows/craft): deploy PDB debug symbol files when using craft

[mgallien]

will enable having proper PDB files deployed when using craft to deploy client dependencies on Windows

[nilsding]

having another CraftMaster config in here is a bit too much duplication for my taste :D

I think we should add a new variable to the [Variables] section instead, reference it inside craftmaster.ini as ${Variables:MyVar}, and pass --variables MyVar=true to the CraftMaster command line parameters (before the -c flag, everything after that is passed to the Craft installation created by CraftMaster as-is).
This would allow us to easily decide to whether we want to create a build with debug symbols enabled or without.

---

Another less-flexible way which will only be useful for CI would be to only add config overrides that are relevant for CI here, i.e. replace this entire file with:

[windows-msvc2022_64-cl]
Packager/DownloadDebugSymbolsCache = False

and change the invocation of CraftMaster.py to include both the default craftmaster.ini and the new craftmaster-CI.ini:

# [...]
      CRAFT_MASTER_CONFIG: ${{ github.workspace }}\craftmaster.ini
      CRAFT_MASTER_CONFIG_CI: ${{ github.workspace }}\craftmaster-CI.ini
# [...]
        shell: pwsh
        run: |
          # [...]
          
          function craft() {
              python "${{ env.CRAFT_MASTER_LOCATION }}\CraftMaster.py" --config "${{ env.CRAFT_MASTER_CONFIG }}" --config-override "${{ env.CRAFT_MASTER_CONFIG_CI }}" --target ${{ env.CRAFT_TARGET }} -c $args
          # [...]

[nilsding]

Looks good, but I think we could even do something better instead

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-8423.zip

Digest: sha256:6489f503ecc5f11329b6a1fdcf4505a432af1e1cf4e9319da1436264f1886794

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud