NETOBSERV-2182 & NETOBSERV-2183 PoC : Filters refactoring

[jpinsonneau]

Description

Update columns configs for netobserv/network-observability-console-plugin#877

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kalmanmeth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[red-hat-konflux]

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
network-observability-operator-bundle-ystream-on-push	json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string
network-observability-operator-ystream-on-push	json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string

[jpinsonneau]

Rebased without changes

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:e8f838b
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e8f838b
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e8f838b

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e8f838b make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e8f838b

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e8f838b
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[openshift-ci]

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	5c7cf32	link	false	/test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jotak]

what exactly does it mean to be targeteable in this context?
Also, searching the web, it seems we should remove the "e": "targetable".

[jotak]

I guess I get what it means, it's a "common" field that can also be specialized into "src/dst" variants, right ?

[jotak]

Thinking out loud - not for this PRs, but I think we could eventually get rid of all the Src/Dst variants in this config file, keep just the targetable, and "expand" it after loading from the console side ? That would shrink this file size and also avoid some repeated content.

[jpinsonneau]

I guess I get what it means, it's a "common" field that can also be specialized into "src/dst" variants, right ?

yeah it can be source, dest, or both