NETOBSERV-1248: informers-only component

[jotak]

Replaces #681

Description

The goal is to allow deploying a dedicated FLP instance as just a k8s informers component, alongside with the "traditional" FLP deployments. The informer is a Kafka producer, and traditional instances are consumers.

• New FLP binary, flp-informers, that just starts the informers and writes update events to Kafka
• New optional config for kubernetes enrichment, allowing to read from kafka instead of using informers

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1248 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

Replaces #681

Description

The goal is to allow deploying a dedicated FLP instance as just a k8s informers component, alongside with the "traditional" FLP deployments. The informer is a Kafka producer, and traditional instances are consumers.

• New FLP binary, flp-informers, that just starts the informers and writes update events to Kafka
• New optional config for kubernetes enrichment, allowing to read from kafka instead of using informers

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

TODO: try with other encoding methods and pick the most efficient one

[codecov]

Codecov Report

Attention: Patch coverage is 23.72881% with 180 lines in your changes missing coverage. Please review.

Project coverage is 64.21%. Comparing base (90b6b5c) to head (7ba2e13).
Report is 41 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/flp-informers/main.go	0.00%	48 Missing ⚠️
...peline/transform/kubernetes/datasource/kafka_ds.go	50.64%	37 Missing and 1 partial ⚠️
...ansform/kubernetes/informers/kafka_cache_writer.go	0.00%	35 Missing ⚠️
...peline/transform/kubernetes/informers/informers.go	0.00%	34 Missing ⚠️
pkg/pipeline/transform/transform_network.go	20.00%	6 Missing and 2 partials ⚠️
...ne/transform/kubernetes/datasource/informers_ds.go	0.00%	6 Missing ⚠️
pkg/pipeline/transform/kubernetes/model/model.go	60.00%	4 Missing and 2 partials ⚠️
pkg/pipeline/transform/kubernetes/enrich.go	44.44%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   65.14%   64.21%   -0.93%     
==========================================
  Files         117      121       +4     
  Lines        8650     8845     +195     
==========================================
+ Hits         5635     5680      +45     
- Misses       2686     2833     +147     
- Partials      329      332       +3     

Flag	Coverage Δ
unittests	64.21% <23.72%> (-0.93%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/api/transform_network.go	100.00% <ø> (ø)
pkg/pipeline/utils/exit.go	100.00% <100.00%> (ø)
pkg/pipeline/transform/kubernetes/enrich.go	73.98% <44.44%> (-2.49%)	⬇️
...ne/transform/kubernetes/datasource/informers_ds.go	0.00% <0.00%> (ø)
pkg/pipeline/transform/kubernetes/model/model.go	60.00% <60.00%> (ø)
pkg/pipeline/transform/transform_network.go	63.48% <20.00%> (-1.64%)	⬇️
...peline/transform/kubernetes/informers/informers.go	18.34% <0.00%> (-0.92%)	⬇️
...ansform/kubernetes/informers/kafka_cache_writer.go	0.00% <0.00%> (ø)
...peline/transform/kubernetes/datasource/kafka_ds.go	50.64% <50.64%> (ø)
cmd/flp-informers/main.go	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.