Skip to content

Conversation

keanu-a
Copy link
Contributor

@keanu-a keanu-a commented Aug 26, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Refactors logic of the initializeImageProxy function to use @netlify/images instead of express function. Removed unit tests for the old logic as well.

Fixes #EX-536


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@keanu-a keanu-a changed the title refactor: change initializeProxy to use ImageHandler refactor: use ImageHandler from @netlify/images Aug 26, 2025
Copy link

github-actions bot commented Aug 26, 2025

📊 Benchmark results

Comparing with 99a2f05

  • Dependency count: 1,077 ⬆️ 0.09% increase vs. 99a2f05
  • Package size: 297 MB ⬆️ 0.01% increase vs. 99a2f05
  • Number of ts-expect-error directives: 382 (no change)

@keanu-a keanu-a marked this pull request as ready for review August 26, 2025 21:03
@keanu-a keanu-a requested a review from a team as a code owner August 26, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant