Skip to content

Conversation

@FerroO2000
Copy link
Contributor

Description

New version of the modal for creating Templates that adds support for defining multiple environments within the same Template.

The scope of this PR is to bridge the gap between the upcoming features of the "multi-environment instance" and "personal workspace".

Features

  • Multi-environment template form
  • Improved form validation

Changes

  • Updated createTemplate mutation
  • ModalCreateTemplate and its sub-components
  • Updated WorkspaceContainer component with the new interfaces

@FerroO2000 FerroO2000 requested a review from a team as a code owner October 1, 2025 17:00
@kingmakerbot
Copy link
Collaborator

Hi @FerroO2000. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

LilloBarilotto and others added 3 commits October 9, 2025 18:45
- Add IP pool management with BuildPrioritizedIPPool for efficient IP reuse
- Implement FindBestIPAndAssignPorts with automatic port assignment
- Add UpdateUsedPortsByIP for LoadBalancer service conflict detection
- Create comprehensive test suite for all IP management functions
- Implement EnforcePublicExposure for service lifecycle management
- Add LoadBalancer service forge functions with proper annotations
- Add IP parsing utilities for flexible pool configuration
- Update Instance and Template CRDs with PublicExposure fields
- Add CLI flags for public exposure configuration
- Include sample templates with public exposure enabled

This enables dynamic IP and port assignment for public exposure
of CrownLabs instances with proper conflict resolution and
comprehensive test coverage.
@QcFe
Copy link
Collaborator

QcFe commented Oct 11, 2025

Ciao @FerroO2000, thanks for your PR. I'd ask you to rebase (easiest way to solve the generated types is ignoring any change during rebase, then deleting and recreating the file with npm run generate). Also if it's the case, please add (as co-author of the commit) the member(s) of group 8 who contributed tho this :)

@FerroO2000
Copy link
Contributor Author

I think i've screwed a little bit the commit history, let me know if I should reopen another PR with a cleaner history

@QcFe
Copy link
Collaborator

QcFe commented Oct 11, 2025

No worries, just squash the commits into one and force-push. There's no need to recreate the PR, it gets updated upon force pushing

FerroO2000 added 3 commits October 11, 2025 15:30
chore: new generated types

feat: create template modal multi environment support

chore: new generated types
@FerroO2000
Copy link
Contributor Author

Sorry, I will reopen a new PR. It is getting worst

@FerroO2000 FerroO2000 closed this Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants