-
Notifications
You must be signed in to change notification settings - Fork 55
[frontend] new form for multi-environment Template creation #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] new form for multi-environment Template creation #978
Conversation
|
Hi @FerroO2000. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
- Add IP pool management with BuildPrioritizedIPPool for efficient IP reuse - Implement FindBestIPAndAssignPorts with automatic port assignment - Add UpdateUsedPortsByIP for LoadBalancer service conflict detection - Create comprehensive test suite for all IP management functions - Implement EnforcePublicExposure for service lifecycle management - Add LoadBalancer service forge functions with proper annotations - Add IP parsing utilities for flexible pool configuration - Update Instance and Template CRDs with PublicExposure fields - Add CLI flags for public exposure configuration - Include sample templates with public exposure enabled This enables dynamic IP and port assignment for public exposure of CrownLabs instances with proper conflict resolution and comprehensive test coverage.
|
Ciao @FerroO2000, thanks for your PR. I'd ask you to rebase (easiest way to solve the generated types is ignoring any change during rebase, then deleting and recreating the file with |
|
I think i've screwed a little bit the commit history, let me know if I should reopen another PR with a cleaner history |
|
No worries, just squash the commits into one and force-push. There's no need to recreate the PR, it gets updated upon force pushing |
chore: new generated types feat: create template modal multi environment support chore: new generated types
|
Sorry, I will reopen a new PR. It is getting worst |
Description
New version of the modal for creating Templates that adds support for defining multiple environments within the same Template.
The scope of this PR is to bridge the gap between the upcoming features of the "multi-environment instance" and "personal workspace".
Features
Changes