Prostoria 534 add matrix field support #10
Conversation
JakovKnezovicc
commented
Jul 25, 2025
JakovKnezovicc
commented
- adds ezmatrix field schema provider
- adds ezmatrix field value visitor
| netgen.openapi_ibexa.ibexa.field_value_schema_provider.matrix: | ||
| class: Netgen\OpenApiIbexa\OpenApi\SchemaProvider\Ibexa\FieldValue\MatrixFieldValueSchemaProvider | ||
| tags: | ||
| - { name: netgen.openapi_ibexa.ibexa.field_value_schema_provider, identifier: ezmatrix } |
There was a problem hiding this comment.
Missing empty line at EOF
Added in 8a9fba3
|
@JakovKnezovicc please resolve PHPStan errors |
| { | ||
| return new Schema\ArraySchema( | ||
| new Schema\ObjectSchema( | ||
| properties: [ |
There was a problem hiding this comment.
Please don't use named parameters, we don't use them here.
I don't have anything against them, but I'd rather keep the code style consistent.
There was a problem hiding this comment.
Adjusted in c84f0a4
| public function visit(object $value, OutputVisitor $outputVisitor, array $parameters = []): array | ||
| { | ||
| return array_map( | ||
| static fn ($row) => $row->getCells(), |
There was a problem hiding this comment.
You can add a return typehint to the arrow function.
There was a problem hiding this comment.
Added in e39cd3c
|
PHPStan needs to be fixed. It is failing because it can't find the classes for Matrix field type.
Scratch that, I see that we already ignore errors based on unavailable field types, so just add an exclusion to |
… for missing classes in neon
|
Thanks @JakovKnezovicc ! |
