Pluralized URL slugs for Custom Object Types #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Feature
161 fix multi object field
Check if unique flag raise validation error if non unique data
NPL-411 raise validation error if using reserved names for fields
Revert "Check if unique flag raise validation error if non unique data"
Update docs for 0.2.0
NPL-389 fix unique check
174 fix delete of CO on detail page
Bump version to 0.2.0 in pyproject.toml
…bose_name/verbose_name_plural in templates
arthanson
reviewed
Aug 22, 2025
| max_length=100, | ||
| unique=True, | ||
| help_text=_("Internal lowercased object name, e.g. \"vendor_policy\""), | ||
| ) |
There was a problem hiding this comment.
It says lowercased but there is no validation or conversion on this, should we enforce that?
netbox_custom_objects/models.py
Outdated
| verbose_name_plural = models.CharField(max_length=100, blank=True) | ||
| slug = models.SlugField(max_length=100, null=True, unique=True, db_index=True) |
There was a problem hiding this comment.
I think we can add the help_text here? same comment above, do we want to enforce lowercase?
Also - do we want this auto-generated off of name (can change but gives a default)?
arthanson
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
verbose_nameandslugfields which allow URL patterns (both for UI and API) to be pluralized, and template usages to adhere to a user-controllable pattern.nameis the "internal" lowercase model name (required)verbose_nameis the human-readable, capitalized and spaced name, optionalverbose_name_pluralis the plural version of the above, optional, (templates will useverbose_name+ "s" if not set)slugis the slugified version ofverbose_name_plural, with aSlugFieldand picker similar to that used in Sites