171 fix ObjectChange for update not showing on restart #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #171
The root issue is get_models wasn't returning the dynamically created CO models on startup. However putting this in causes a recursion error when you go to create a new COT - as the type() call in get_model if you are creating a new object calls into get_models, which calls get_model (recursion).
Where this happens is in the clear_cache routine as it clears the apps cache and then reloads all the models from get_models. So this monkey-patches the clear_cache code to do a no-op until the type is actually created, then once the model is added to the cache it calls clear_cache which is safe to call now as get_models->get_model will just return the cached model thus avoiding the infinite recursion.