Fixes #20610: Correct VLAN ID range calculation logic #20611
Merged
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
|
Thanks for all the release work! No pressure if the window has closed. I completely understand. I can rebase or adjust anything right away if that helps. Thanks again for your time and for everything you do. |
|
I'll try to review this tomorrow ahead of the v4.4.5 release if @bctiemann hasn't had a chance yet. |
netbox/ipam/migrations/0083_vlangroup_populate_total_vlan_ids.py
Outdated
Show resolved
Hide resolved
Adjust VLAN ID range calculation to use half‑open intervals for consistency. Add a test to validate `_total_vlan_ids`. Fixes netbox-community#20610
pheus
force-pushed
the
20610-vlangroup-total-vlan-ids-off-by-one
branch
from
369cd6a to
05fd14a
Compare
|
Thanks for the thoughtful review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20610
Correct an off‑by‑one in
VLANGroup._total_vlan_idsby computing lengths with half‑open[lo, hi)semantics duringsave(). Removes the+1, adds a test and includes a data migration to backfill existing_total_vlan_ids.No schema changes.