[server] add interface name to DNS state on Darwin #4633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug on Darwin where different instances of netbird clobber each other's DNS entries: disambiguate 'netbirdDNSStateKeyFormat' by including the interface name. Signed-off-by: Sirio Balmelli <[email protected]>
|
|
|
|
@nazarewk you might be interested in this; combined with nix-darwin/nix-darwin#1610 it allows participating in multiple independent overlay networks on a single nix-darwin host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix bug on Darwin where different instances of netbird clobber each other's DNS entries:
disambiguate 'netbirdDNSStateKeyFormat' by including the interface name.
Issue ticket number and link
Related to #446: allows proper DNS resolution when multiple server instances are run on Darwin/MacOS, each instance with its own interface and state.
Stack
Checklist
Documentation
Select exactly one:
It is reasonable to assume that multiple instances of
netbird servercan run on a Darwin machine, as long as they bind to different interfaces and have separate runtime and state directories; in this case each should push its own independent resolver record to the resolver.This is already the case on Linux, and this bugfix brings feature parity to Darwin.