-
-
Notifications
You must be signed in to change notification settings - Fork 908
[client] handle missed global management url flag in login cmd #4609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the handling of the disable_firewall
configuration flag in the login command by ensuring it's properly passed through the gRPC configuration APIs.
Key changes:
- Added
DisableFirewall
field to the gRPC protocol definition and generated code - Implemented proper configuration handling for the firewall setting during login
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
client/proto/daemon.proto | Added disable_firewall field to GetConfigResponse message |
client/proto/daemon.pb.go | Auto-generated protobuf code including new field and getter method |
client/server/server.go | Added firewall configuration to the gRPC response |
client/cmd/login.go | Added configuration setup logic to handle firewall settings during login |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
reflect "reflect" | ||
sync "sync" | ||
unsafe "unsafe" | ||
|
||
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
_ "google.golang.org/protobuf/types/descriptorpb" | ||
durationpb "google.golang.org/protobuf/types/known/durationpb" | ||
timestamppb "google.golang.org/protobuf/types/known/timestamppb" |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Import reordering should be handled by gofmt or goimports rather than manual changes. Generated protobuf files should typically maintain consistent import ordering.
reflect "reflect" | |
sync "sync" | |
unsafe "unsafe" | |
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
_ "google.golang.org/protobuf/types/descriptorpb" | |
durationpb "google.golang.org/protobuf/types/known/durationpb" | |
timestamppb "google.golang.org/protobuf/types/known/timestamppb" | |
"reflect" | |
"sync" | |
"unsafe" | |
"google.golang.org/protobuf/reflect/protoreflect" | |
"google.golang.org/protobuf/runtime/protoimpl" | |
_ "google.golang.org/protobuf/types/descriptorpb" | |
"google.golang.org/protobuf/types/known/durationpb" | |
"google.golang.org/protobuf/types/known/timestamppb" |
Copilot uses AI. Check for mistakes.
Describe your changes
[client] handle missed global management url flag in login cmd
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__