-
-
Notifications
You must be signed in to change notification settings - Fork 905
[management] feat: Basic PocketID IDP integration #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While implementing this, I did run into some confusion when looking at the zitadel and keycloak implementation. Is it intentional that updating the app metadata is optional? PocketID also does not have the direct concept of app metadata, though you could probably work something out using custom claims. |
Hello @hakansa @pascal-fischer! Would it be possible to get a review? |
I tested this on my local self-hosted instance and it works well @jfrconley I'm gonna look into code one more time and I think that we are good to merge |
management/server/idp/pocketid.go
Outdated
} | ||
|
||
// TODO: read and intepret PocketID Error | ||
return nil, fmt.Errorf("Unexpected status code: %d", resp.StatusCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to be more specific in the message and mention that the error originates from PocketID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. I updated the messaging to specify that the unexpected status code comes from the pocket id API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the suggestions, plz
|
@jfrconley Thank you for the contribution! |
Turbocool, can't wait to try this. Sorry to bother you with this but @jfrconley , @braginini do anyone of you know if there's docker builds for the |
Describe your changes
Add support for integrating pocketid with netbird, allowing user information to be properly synced and displayed.
The goal is to bring support inline with integrations for other self hosted idp's with this implementation cribbing heavily from the existing keycloak and zitadel integrations.
This takes advantage of the PocketID REST API to do basic user data management.
Issue ticket number and link
This should fix the issue described in #3295, populating the email and name fields in the profile from data returned by PocketID
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
netbirdio/docs#432