Skip to content

Conversation

@nvbien2000
Copy link

Describe your changes

  • I create a Windows installer file .exe. After I installed it, the shortcut and uninstaller icon is empty. The "uninstaller icon is empty" issue exists on NetBird production v0.5.61 also.
  • This change aims to fix above issue.
  • I also ignore .exe, .pkg, .deb from Git.

Example:
netbird1

Issue ticket number and link

  • None

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (small fix, no need documentation)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

@nvbien2000 nvbien2000 changed the title fix Windows's shortcut & uninstaller icon don't display; ignore installer files (.exe/pkg/deb) from Git [client] fix Windows's shortcut & uninstaller icon don't display; ignore installer files (.exe/pkg/deb) from Git Sep 11, 2025
@sonarqubecloud
Copy link

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2025

CLA assistant check
All committers have signed the CLA.

@mlsmaycon
Copy link
Collaborator

@nvbien2000 thanks for the contribution.

I just want to check if you validated the shortcut icon using a syso file as in the following workflow:

https://github.com/netbirdio/netbird/blob/main/.github/workflows/release.yml#L80

@nvbien2000
Copy link
Author

@mlsmaycon Hello Maycon. I haven't used that syso working flow. All I did is just running this command makensis -V4 client/installer.nsis in Contributing.md guideline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants