Skip to content

fix(ruby_lsp): prevent duplicate clients on second buffer #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ruby_lsp): prevent duplicate clients on second buffer #4132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lsp/ruby_lsp.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ return {
init_options = {
formatter = 'auto',
},
reuse_client = function(client, config)
before_init = function(_, config)
config.cmd_cwd = config.root_dir
Copy link
Member

@justinmk justinmk Oct 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly, before_init happens after the cmd is invoked, which means setting the cmd_cwd won't have the effect that was intended here.

return client.config.cmd_cwd == config.cmd_cwd
end,
}