fix(css_variables): update root directory #4127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Root directory is incorrect for projects containing a
package.jsonfile in subdirectories.For a project with a given file structure:
The LSP is using
my-featureas the root directory. This directory is not the one where the css variables are defined. It leads to an issue where the css variables are not indexed, and fromfeature-component-a.module.cssauto-completion and jump to definition are not working.Solution
Using the same
root_dirlogic asts_ls(which prefers lockfiles like yarn.lock or .git as root markers) correctly sets the project root tomy-monorepo/, allowingcss/css-variables/to be discoverable for the LSP.