-
-
Notifications
You must be signed in to change notification settings - Fork 140
BUGFIX: add feedback to switch to new document in tree on cut and copy #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pKallert
wants to merge
2
commits into
neos:8.3
Choose a base branch
from
pKallert:bugfix/redirect-copy-cut-in-document-tree
base: 8.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BUGFIX: add feedback to switch to new document in tree on cut and copy #3918
pKallert
wants to merge
2
commits into
neos:8.3
from
pKallert:bugfix/redirect-copy-cut-in-document-tree
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9f9c08
to
1f3f32d
Compare
mhsdesign
reviewed
Feb 21, 2025
mhsdesign
reviewed
Mar 27, 2025
Co-authored-by: Marc Henry Schultz <[email protected]>
Sebobo
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thx!
@pKallert can you retry the test, I cannot trigger it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3917
What I did
When using cut/copy in the document tree, the user is not automatically redirected to the "new" page.
How I did it
To keep it consistent with all other operations in the content/document tree I added feedback in the operations that will lead to the user being on the new page
How to verify it
When using cut/copy/create in both the document and content tree, the user is always redirected to the "new" node.