Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace Neo4j.Driver.Internal.Mapping.ConventionTranslation;

public class NoOpConventionTranslator : IConventionTranslator
internal class NoOpConventionTranslator : IConventionTranslator
{
/// <inheritdoc />
public string Translate(string input)
Expand Down
1 change: 1 addition & 0 deletions Neo4j.Driver/Neo4j.Driver/Internal/Routing/LoadBalancer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public LoadBalancer(
/// <summary>TEST ONLY.</summary>
/// <param name="clusterConnPool"></param>
/// <param name="routingTableManager"></param>
/// <param name="driverContext"></param>
internal LoadBalancer(
IClusterConnectionPool clusterConnPool,
IRoutingTableManager routingTableManager,
Expand Down
2 changes: 1 addition & 1 deletion Neo4j.Driver/Neo4j.Driver/Internal/Util/VarLong.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

namespace Neo4j.Driver.Internal.Util;

public class VarLong
internal class VarLong
{
public long Value { get; private set; }
private byte _position = 0;
Expand Down
10 changes: 9 additions & 1 deletion Neo4j.Driver/Neo4j.Driver/Public/Exceptions/Neo4jException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,15 @@ public Neo4jException(string code, string message, Exception innerException)
Code = code;
}

/// <summary>Gets whether the exception retriable or not.</summary>
/// <summary>
/// Gets whether the exception is retryable or not.
/// Important Note: Methods that use Autocommit transactions
/// <see cref="Neo4j.Driver.IAsyncSession.RunAsync(string, System.Action{Neo4j.Driver.TransactionConfigBuilder})"/>,
/// <see cref="Neo4j.Driver.IAsyncSession.RunAsync(string, System.Collections.Generic.IDictionary{string, object}, System.Action{Neo4j.Driver.TransactionConfigBuilder})"/>,
/// and
/// <see cref="Neo4j.Driver.IAsyncSession.RunAsync(Neo4j.Driver.Query, System.Action{Neo4j.Driver.TransactionConfigBuilder})"/>
/// are not retryable regardless of this value.
/// </summary>
public virtual bool IsRetriable => false;

/// <summary>Gets or sets the code of a Neo4j exception.</summary>
Expand Down
20 changes: 10 additions & 10 deletions Neo4j.Driver/Neo4j.Driver/Public/IAsyncSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ Task<TResult> ExecuteWriteAsync<TResult>(
Task CloseAsync();

/// <summary>
/// Asynchronously run a query with the specific <see cref="TransactionConfig"/> and return a task of result
/// stream. This method accepts a String representing a Cypher query which will be compiled into a query object that can be
/// used to efficiently execute this query multiple times. This method optionally accepts a set of parameters which will be
/// injected into the query object query by Neo4j.
/// Asynchronously run a query within an AutoCommit transaction. Uses the specific <see cref="TransactionConfig"/>
/// and returns a task of result stream. This method accepts a String representing a Cypher query which will be
/// compiled into a query object that can be used to efficiently execute this query multiple times. This method
/// optionally accepts a set of parameters which will be injected into the query object query by Neo4j.
/// </summary>
/// <param name="query">A Cypher query.</param>
/// <param name="action">
Expand All @@ -199,10 +199,10 @@ Task<TResult> ExecuteWriteAsync<TResult>(
Task<IResultCursor> RunAsync(string query, Action<TransactionConfigBuilder> action = null);

/// <summary>
/// Asynchronously run a query with the customized <see cref="TransactionConfig"/> and return a task of result
/// stream. This method accepts a String representing a Cypher query which will be compiled into a query object that can be
/// used to efficiently execute this query multiple times. This method optionally accepts a set of parameters which will be
/// injected into the query object query by Neo4j.
/// Asynchronously run a query within an AutoCommit transaction. Uses the specific <see cref="TransactionConfig"/>
/// and returns a task of result stream. This method accepts a String representing a Cypher query which will be
/// compiled into a query object that can be used to efficiently execute this query multiple times. This method
/// optionally accepts a set of parameters which will be injected into the query object query by Neo4j.
/// </summary>
/// <param name="query">A Cypher query.</param>
/// <param name="parameters">Input parameters for the query.</param>
Expand All @@ -217,8 +217,8 @@ Task<IResultCursor> RunAsync(
Action<TransactionConfigBuilder> action = null);

/// <summary>
/// Asynchronously execute a query with the specific <see cref="TransactionConfig"/> and return a task of result
/// stream.
/// Asynchronously run a query within an AutoCommit transaction. Uses the specific <see cref="TransactionConfig"/>
/// and return a task of result stream.
/// </summary>
/// <param name="query">A Cypher query, <see cref="Query"/>.</param>
/// <param name="action">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class StandardCaseParser : IIdentifierParser<IReadOnlyList<string>>
/// Initializes a new instance of the <see cref="StandardCaseParser"/> class.
/// </summary>
/// <param name="convention">The naming convention to use.</param>
/// <exception cref="ArgumentOutOfRangeException">Thrown when an unsupported convention is provided.</exception>
/// <exception cref="System.ArgumentOutOfRangeException">Thrown when an unsupported convention is provided.</exception>
public StandardCaseParser(IdentifierCaseConvention convention)
{
(_validationRegex, _splitRegex) = convention switch
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ void IRecordObjectMapping.TranslateIdentifiers(IConventionTranslator conventionT
_conventionTranslator = conventionTranslator;
}

public static void TranslateIdentifiers(IConventionTranslator conventionTranslator)
private static void TranslateIdentifiers(IConventionTranslator conventionTranslator)
{
((IRecordObjectMapping)Instance).TranslateIdentifiers(conventionTranslator);
}
Expand Down
8 changes: 7 additions & 1 deletion Neo4j.Driver/Neo4j.Driver/Public/TransactionConfig.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ public sealed class TransactionConfig
private IDictionary<string, object> _metadata = new Dictionary<string, object>();
private TimeSpan? _timeout;

// constructor with two optional parameters
/// <summary>
/// Constructor with two optional parameters
/// </summary>
/// <param name="metadata">A dictionary of key-value pairs to attach as metadata to the transaction.</param>
/// <param name="timeout">The transaction timeout. Transactions running longer than this duration will be terminated
/// by the database. If null, the server's default timeout is used. A value of zero means the transaction will
/// execute indefinitely.</param>
public TransactionConfig(IDictionary<string, object> metadata = null, TimeSpan? timeout = null)
{
Metadata = metadata ?? new Dictionary<string, object>();
Expand Down