-
Notifications
You must be signed in to change notification settings - Fork 4
feat: use external header file and schema option for admin import example #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fbiville
wants to merge
4
commits into
main
Choose a base branch
from
admin_import_header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fa0b75
to
3fe1663
Compare
978d78d
to
a26297d
Compare
8433de8
to
63f856c
Compare
61e498b
to
075543c
Compare
d25e0a2
to
ce050fe
Compare
ali-ince
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maybe also remove duckdb from dependencies?
@ali-ince we still use DuckDB in the admin-import example to read the parquet file's columns: // 🐤
private static List<String> readFieldNames(Source source) throws Exception {
try (var connection = DriverManager.getConnection("jdbc:duckdb:");
var statement = connection.prepareStatement("DESCRIBE (SELECT * FROM read_parquet($1))")) {
statement.setString(1, ((ParquetSource) source).uri());
var fields = new ArrayList<String>();
try (var results = statement.executeQuery()) {
while (results.next()) {
fields.add(results.getString(1));
}
}
return fields;
}
} |
Multiple group IDs are not supported by admin-import.
This is supported since 2025.02 (only for the now-default block format). Note: schema statements used to be executed separately after a data conversion hack. Since they now run prior to that hack, I had to comment out one specific type constraint that cannot be satisified until our Parquet importer supports date types.
ce050fe
to
4ee5a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.