Skip to content

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Apr 23, 2025

No description provided.

@fbiville fbiville force-pushed the admin_import_header branch 3 times, most recently from 3fa0b75 to 3fe1663 Compare April 23, 2025 20:14
@neo4j neo4j deleted a comment from neo4j-connectors Apr 23, 2025
@fbiville fbiville force-pushed the admin_import_header branch 2 times, most recently from 978d78d to a26297d Compare May 5, 2025 10:21
@fbiville fbiville force-pushed the main branch 4 times, most recently from 8433de8 to 63f856c Compare June 3, 2025 16:40
@fbiville fbiville force-pushed the admin_import_header branch 2 times, most recently from 61e498b to 075543c Compare June 5, 2025 08:51
@fbiville fbiville marked this pull request as ready for review June 6, 2025 10:23
@fbiville fbiville requested a review from a team as a code owner June 6, 2025 10:23
@fbiville fbiville requested review from meistermeier and ali-ince June 6, 2025 10:23
@fbiville fbiville changed the title feat: use external header file in admin import demo feat: use external header file and schema option for admin import example Jun 6, 2025
@neo4j-connectors
Copy link
Collaborator

neo4j-connectors commented Jun 6, 2025

Warnings
⚠️ ❗ Please include a description of your PR changes.

Pull request should have a description of the underlying changes.

Generated by 🚫 dangerJS against 4ee5a99

@fbiville fbiville force-pushed the admin_import_header branch 2 times, most recently from d25e0a2 to ce050fe Compare June 18, 2025 15:22
Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe also remove duckdb from dependencies?

@fbiville
Copy link
Contributor Author

@ali-ince we still use DuckDB in the admin-import example to read the parquet file's columns:

        // 🐤
        private static List<String> readFieldNames(Source source) throws Exception {
            try (var connection = DriverManager.getConnection("jdbc:duckdb:");
                    var statement = connection.prepareStatement("DESCRIBE (SELECT * FROM read_parquet($1))")) {
                statement.setString(1, ((ParquetSource) source).uri());
                var fields = new ArrayList<String>();
                try (var results = statement.executeQuery()) {
                    while (results.next()) {
                        fields.add(results.getString(1));
                    }
                }
                return fields;
            }
        }

fbiville added 4 commits June 27, 2025 10:59
Multiple group IDs are not supported by admin-import.
This is supported since 2025.02 (only for the now-default block
format).

Note: schema statements used to be executed separately after a
data conversion hack. Since they now run prior to that hack,
I had to comment out one specific type constraint that cannot be
satisified until our Parquet importer supports date types.
@fbiville fbiville force-pushed the admin_import_header branch from ce050fe to 4ee5a99 Compare June 27, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants