Skip to content

Conversation

thief-sty
Copy link

This closes #138 by upgrading arrow to 56.0.0 (latest).

@s1ck
Copy link
Collaborator

s1ck commented Aug 19, 2025

@thief-sty Thanks for the PR, I will have a look at it towards the end of the week.

Copy link
Collaborator

@s1ck s1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the dependencies. These major version bumps in arrow are quite an annoyance.
Would you mind addressing the linting issue so that we get a green build? Thanks

&self,
_request: Request<FlightDescriptor>,
) -> FlightResult<Response<PollInfo>> {
Err(Status::unimplemented("Not yet implemented"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s1ck
Copy link
Collaborator

s1ck commented Aug 22, 2025

@thief-sty I did continue a bit on your changes. Fixing the current clippy warning about elided lifetimes, will bring you to the problem that the Error in the result type is too large. This is being addressed in tonic 0.14 by boxing the Status. However, arrow 56.0.0 depends on tonic 0.13, which does not include the change.

Unless you have a better proposal, I am fine with allowing the lint for the time being in server/main.rs:

#![allow(result_large_err)]

and removing that line once arrow upgraded to tonic 0.14.

The remaining error is a deprecation warning, which you can fix by:

    fn try_from(descriptor: FlightDescriptor) -> Result<Self, Self::Error> {
        match DescriptorType::try_from(descriptor.r#type) {
            Err => Err(Status::invalid_argument(format!(
                "unsupported descriptor type: {}",
                descriptor.r#type
            ))),
            Ok(DescriptorType::Cmd) => {
                serde_json::from_slice::<Self>(&descriptor.cmd).map_err(from_json_error)
            }
            Ok(descriptor_type) => Err(Status::invalid_argument(format!(
                "Expected command, got {descriptor_type:?}"
            ))),
        }
    }

After that, clippy should be happy with the PR.

@thief-sty
Copy link
Author

Bumping this just in case you didn't see my commits from last week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build
2 participants