shellwords only parses lines that are defined #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using perl 5.34.1 on MacOS with perl provided by Macports, the following produces a warning:
It's possible many modules (like Devel::CheckLib here) will accidentally call shellwords with an undefined value. The PR suppresses that warning by only doing the substitution if $line is defined in ParseWords.pm line 21.
I wanted to include a test in ParseWords.t, something like this:
but I could not get
make test
to fail with the existing unpatched code. Perhaps you have a better idea.