-
Notifications
You must be signed in to change notification settings - Fork 2
chore: added deterministic tests #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 88.03% 88.20% +0.17%
==========================================
Files 41 41
Lines 9102 9372 +270
Branches 9102 9372 +270
==========================================
+ Hits 8013 8267 +254
- Misses 642 658 +16
Partials 447 447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DSharifi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these changes! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to address this ugliness (and lack of efficiency, as afaik we send this over the wire) here. The bad part is that this would be a breaking change :| (incompatible with nodes running other version type)
d36be11 to
aac3704
Compare
Closes #107
OsRngin these files is preferred, as currently they are the closest we have to usage examples.