fix: OSD: concatenate multiline typical pedon horizons #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownag
commented
Sep 15, 2025
| "distinctness": "gradual", | ||
| "topography": "wavy", | ||
| "narrative": "AB--7 to 12 inches; pale brown (10YR 6/3) gravelly ashy sandy loam, dark brown (10YR 3/3) moist; moderate medium subangular blocky structure; slightly hard, friable, slightly sticky and slightly plastic; many fine, medium, and common coarse roots; common fine irregular pores; 20 percent gravel; neutral (pH 7.2); gradual wavy boundary. (3 to 6 inches thick)" | ||
| "narrative": "AB--7 to 12 inches; pale brown (10YR 6/3) gravelly ashy sandy loam, dark brown (10YR 3/3) moist; moderate medium subangular blocky structure; slightly hard, friable, slightly sticky and slightly plastic; many fine, medium, and common coarse roots; common fine irregular pores; 20 percent gravel; neutral (pH 7.2); gradual wavy boundary. (3 to 6 inches thick) Bw[r1]--12 to 21 inches; pale brown (10YR 6/3) gravelly coarse sandy loam, dark yellowish brown (10YR 4/4) moist; moderate medium subangular blocky structure; slightly hard, friable, slightly sticky and slightly plastic; common fine, medium, and few coarse roots; common fine irregular pores; 20 percent gravel; neutral (pH 7.2); clear wavy boundary. (5 to 10 inches thick)" |
Member
Author
There was a problem hiding this comment.
NB: "Bw[r1]" in ARDENMONT does not match horizon pattern
brownag
commented
Sep 15, 2025
Member
Author
brownag
left a comment
brownag
left a comment
There was a problem hiding this comment.
overall this appears to have worked well. There are instances e.g. ARDENMONT where an incorrectly formatted horizon that was previously not parsed is now included in the narrative for an overlying horizon. This can probably be fixed in the next horizon rules revision PR
brownag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #83