Arbeidslivssenter-sider #2567
Arbeidslivssenter-sider #2567
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👀 Visual changes detected
Please review the screenshot changes before merging.
bdahle
force-pushed
the
arbeidslivssenter-v3
branch
from
b331e92 to
d353d39
Compare
…yles in OfficeDetails and PhonePoster components
packages/nextjs/src/components/pages/office-page/officeDetails/OfficeDetails.tsx
Outdated
Show resolved
Hide resolved
bdahle
had a problem deploying
to
dev-gcp:dev1
GitHub Actions
Failure
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for Arbeidslivssenter (ALS) office pages to the existing office page template. It introduces conditional rendering based on office type and adds new components for ALS-specific features.
Key Changes
- Added support for ALS office type alongside existing office (LOKAL) and HMS types
- Introduced new components: Kontaktskjema (contact form) and LinkedIn section for ALS pages
- Restructured phone and organization information display logic
- Updated translations for ALS-specific content across all languages (nb/nn/en)
Reviewed changes
Copilot reviewed 22 out of 36 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/nextjs/src/types/content-props/dynamic-page-props.ts |
Added optional linkedin field to OfficePageProps |
packages/nextjs/src/translations/default.ts |
Added Norwegian translations for ALS-specific content |
packages/nextjs/src/translations/nn.ts |
Added Nynorsk translations for ALS-specific content |
packages/nextjs/src/translations/en.ts |
Split phone time and information translations |
packages/nextjs/src/components/pages/office-page/officeDetails/phonePoster/PhonePoster.tsx |
Added ALS-specific logic for phone information display |
packages/nextjs/src/components/pages/office-page/officeDetails/officeInformation/OfficeInformation.tsx |
Restructured organization and office number display |
packages/nextjs/src/components/pages/office-page/officeDetails/kontaktskjema/Kontaktskjema.tsx |
New component for ALS contact form section |
packages/nextjs/src/components/pages/office-page/officeDetails/OfficeDetails.tsx |
Integrated Kontaktskjema and conditional heading for ALS |
packages/nextjs/src/components/pages/office-page/office-page-header/OfficePageHeader.tsx |
Added ALS tagline support |
packages/nextjs/src/components/pages/office-page/linkedIn/LinkedIn.tsx |
New component for LinkedIn follow section |
packages/nextjs/src/components/pages/office-page/OfficePage.tsx |
Added ALS type handling and LinkedIn component integration |
packages/nextjs/src/components/pages/office-page/*.module.scss |
Updated styling for improved layout and spacing |
packages/nextjs/package.json |
Bumped @navikt/nav-office-reception-info to 1.4.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Heading level="2" size="large" className={styles.header}> | ||
| {getOfficeTranslations('youFindUsHere')} | ||
| <Heading level="2" size="large"> | ||
| {officeData.type == 'ALS' |
There was a problem hiding this comment.
Use strict equality operator (===) instead of loose equality (==). This prevents potential type coercion issues.
| /> | ||
| )} | ||
| <PhonePoster officeData={officeData} /> | ||
| {officeData.type == 'ALS' && <Kontaktskjema />} |
There was a problem hiding this comment.
Use strict equality operator (===) instead of loose equality (==). This prevents potential type coercion issues.
| {officeData.type == 'ALS' && <Kontaktskjema />} | |
| {officeData.type === 'ALS' && <Kontaktskjema />} |
| return ( | ||
| <div className={styles.kontaktskjema}> | ||
| <Heading level="3" size="small" spacing> | ||
| Kontaktskjema |
There was a problem hiding this comment.
The heading "Kontaktskjema" is hardcoded in Norwegian. It should use a translation key instead to support all languages (nb/nn/en). Consider adding a translation like getOfficeTranslations('contactForm') and adding the corresponding entries to translation files.
| Kontaktskjema | |
| {getOfficeTranslations('contactForm')} |
| <div className={styles.linkedinWrapper}> | ||
| <div className={styles.linkedIn}> | ||
| <Heading level="2" size="large" spacing> | ||
| Følg oss på LinkedIn |
There was a problem hiding this comment.
The heading "Følg oss på LinkedIn" is hardcoded in Norwegian. It should use a translation key instead to support all languages (nb/nn/en). Consider adding a translation like getOfficeTranslations('followUsOnLinkedIn') and adding the corresponding entries to translation files.
Oppsummering av hva som er gjort
Henger sammen med navikt/nav-enonicxp#2486
Testing
Testes i dev